[Merged by Bors] - feat(SmartModule): Initial support for SmartEngine v2 #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
force-pushed
the
smartmodule_init
branch
2 times, most recently
from
33f4407
to
4cbc5e7
Compare
sehz
changed the title
remove pre-parameter passing
update example
sehz
force-pushed
the
smartmodule_init
branch
from
3695d89
to
30eb5c9
Compare
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 22, 2022
Introducing SmartModule with Init. Init allows SmartModule to have the configuration lifecycle vs. runtime. V2 SmartEngine has the following primitives: * SmartModuleChainBuilder * SmartModuleChainInstance * Transforms Use `SmartChainBuilder` to build a SmartModule chain. A chain can consist of multiple SmartModule. For now, only a SmartModule is processed but can expand to multiple SmartModule soon. If at least one SmartModule is in the chain, it can be turned into `ChainInstance` by initializing. During initialization, the configuration parameter associated with each SmartModule is passed to "Init" in each SmartModule. During the initialization phase, the SmartModule can do whatever it needs to configure. Once the instance is initialized, it can process records by SPU, Connector, or other records feeder. Major changes are * SmartModule parameters are no longer passed to transforms. It is only passed to Init. * Introduce the "Init" section in the SmartModule declaration. * File batch processing is migrated to SPU only. SmartEngine only handles the records from now on. * Join Transform API still exists but is not supported now. It will be added back later * Lots of API and structure name cleanup to clarify meanings
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
Introducing SmartModule with Init. Init allows SmartModule to have the configuration lifecycle vs. runtime. V2 SmartEngine has the following primitives: * SmartModuleChainBuilder * SmartModuleChainInstance * Transforms Use `SmartChainBuilder` to build a SmartModule chain. A chain can consist of multiple SmartModule. For now, only a SmartModule is processed but can expand to multiple SmartModule soon. If at least one SmartModule is in the chain, it can be turned into `ChainInstance` by initializing. During initialization, the configuration parameter associated with each SmartModule is passed to "Init" in each SmartModule. During the initialization phase, the SmartModule can do whatever it needs to configure. Once the instance is initialized, it can process records by SPU, Connector, or other records feeder. Major changes are * SmartModule parameters are no longer passed to transforms. It is only passed to Init. * Introduce the "Init" section in the SmartModule declaration. * File batch processing is migrated to SPU only. SmartEngine only handles the records from now on. * Join Transform API still exists but is not supported now. It will be added back later * Lots of API and structure name cleanup to clarify meanings
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing SmartModule with Init. Init allows SmartModule to have the configuration lifecycle vs. runtime.
V2 SmartEngine has the following primitives:
Use
SmartChainBuilderto build a SmartModule chain. A chain can consist of multiple SmartModule. For now, only a SmartModule is processed but can expand to multiple SmartModule soon. If at least one SmartModule is in the chain, it can be turned intoChainInstanceby initializing. During initialization, the configuration parameter associated with each SmartModule is passed to "Init" in each SmartModule. During the initialization phase, the SmartModule can do whatever it needs to configure. Once the instance is initialized, it can process records by SPU, Connector, or other records feeder.Major changes are