[Merged by Bors] - fix(stream_model): prevent collisions between namespaces #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
reviewed
Aug 4, 2022
| @@ -163,11 +163,13 @@ pub trait K8ExtendedSpec: Spec { | |||
|
|
|||
| fn convert_from_k8( | |||
| k8_obj: K8Obj<Self::K8Spec>, | |||
| multi_namespace_context: bool, | |||
| ) -> Result<MetadataStoreObject<Self, K8MetaItem>, K8ConvertError<Self::K8Spec>>; | |||
| } | |||
|
|
|||
| pub fn default_convert_from_k8<S>( | |||
There was a problem hiding this comment.
I think that we should add some references to the way that we should use fluvio_stream_dispatcher::store::StoreContext when using multiple namespaces for all the methods that have key: S::IndexKey as a parameter. Maybe as docstrings?
There was a problem hiding this comment.
added docstring to default_convert_from_k8
morenol
approved these changes
Aug 5, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
Co-authored-by: Nick Cardin <nick@cardin.email>
simlay
approved these changes
Aug 5, 2022
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
|
Can you add more description to this PR? Or should this have an associated issue describing API changes would intendend |
|
This is probably not fix since this is not bug fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.