Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make version required in connector yaml #2472

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Make version required in connector yaml #2472

wants to merge 8 commits into from

Conversation

simlay
Copy link
Contributor

@simlay simlay commented Jul 12, 2022

Closes #2456.

@ajhunyady
Copy link
Contributor

Is this change backward compatible?

@simlay
Copy link
Contributor Author

simlay commented Jul 12, 2022

Is this change backward compatible?

Yes.

@simlay simlay requested review from morenol and sehz July 12, 2022 17:34
sehz
sehz requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a negative test? if required version is missing, it should fail

sehz
sehz approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

morenol
morenol approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@simlay simlay force-pushed the make-connector-version-required branch from f678211 to 5477d39 Compare July 12, 2022 20:54
@simlay
Copy link
Contributor Author

simlay commented Jul 12, 2022

bors r+

@bors
Copy link

bors bot commented Jul 12, 2022

Merge conflict.

@simlay simlay force-pushed the make-connector-version-required branch from 9256b41 to fad3be2 Compare July 12, 2022 23:50
@simlay
Copy link
Contributor Author

simlay commented Jul 12, 2022

bors retry

bors bot pushed a commit that referenced this pull request Jul 12, 2022
@simlay
Make version required in connector yaml (#2472)
d9ee226 
Closes #2456.
@bors
Copy link

bors bot commented Jul 13, 2022

Build failed:

@tjtelan
Copy link
Contributor

tjtelan commented Jul 13, 2022

bors retry

bors bot pushed a commit that referenced this pull request Jul 13, 2022
@simlay
Make version required in connector yaml (#2472)
ebb21c3 
Closes #2456.
@tjtelan
Copy link
Contributor

tjtelan commented Jul 13, 2022

@simlay

The reason Bors can't merge because fluvio check test is failing.
https://github.com/infinyon/fluvio/runs/7312057421?check_suite_focus=true

@bors
Copy link

bors bot commented Jul 13, 2022

Canceled.

@simlay
Copy link
Contributor Author

simlay commented Jul 13, 2022

@simlay

The reason Bors can't merge because fluvio check test is failing. https://github.com/infinyon/fluvio/runs/7312057421?check_suite_focus=true

Ugh, forgot to add the file. It's there now.

@simlay
Copy link
Contributor Author

simlay commented Jul 13, 2022

@bors retry

@tjtelan
Copy link
Contributor

tjtelan commented Jul 13, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 13, 2022
@simlay
Make version required in connector yaml (#2472)
ebb3654 
Closes #2456.
@bors
Copy link

bors bot commented Jul 13, 2022

Build failed:

@simlay
Copy link
Contributor Author

simlay commented Jul 13, 2022

bors retry

bors bot pushed a commit that referenced this pull request Jul 13, 2022
@simlay
Make version required in connector yaml (#2472)
79f4bd7 
Closes #2456.
@bors
Copy link

bors bot commented Jul 13, 2022

Build failed:

@sehz
Copy link
Contributor

sehz commented Jul 13, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jul 13, 2022
@simlay
Make version required in connector yaml (#2472)
fd1fa81 
Closes #2456.
@bors
Copy link

bors bot commented Jul 13, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Make version required in connector yaml [Merged by Bors] - Make version required in connector yaml Jul 13, 2022
@bors bors bot closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@morenol morenol morenol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connector: Enforce version field as mandatory
5 participants
@simlay @ajhunyady @tjtelan @sehz @morenol