Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix some typo Event change_listener #2382

Closed
wants to merge 4 commits into from

Conversation

ilaborie
Copy link
Contributor

Fix typo in fluvio_types::event::offsets::OffsetPublisher:

  • deprecate change_listner
  • replace by change_listener

@ilaborie ilaborie mentioned this pull request May 14, 2022
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a patch bump in fluvio and fluvio-types crates. Once that is done, I think that this is ready to merge

@morenol morenol requested a review from sehz May 24, 2022 14:50
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Lets add to changelog

@morenol morenol requested a review from sehz May 24, 2022 15:10
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sehz
Copy link
Contributor

sehz commented May 24, 2022

bors r+

bors bot pushed a commit that referenced this pull request May 24, 2022
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`:

* deprecate `change_listner`
* replace by `change_listener`


Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
@bors
Copy link

bors bot commented May 24, 2022

Build failed:

@sehz
Copy link
Contributor

sehz commented May 24, 2022

bors r+

bors bot pushed a commit that referenced this pull request May 24, 2022
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`:

* deprecate `change_listner`
* replace by `change_listener`


Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
@bors
Copy link

bors bot commented May 24, 2022

Build failed:

@morenol
Copy link
Contributor

morenol commented May 24, 2022

bors retry

bors bot pushed a commit that referenced this pull request May 24, 2022
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`:

* deprecate `change_listner`
* replace by `change_listener`


Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
@bors
Copy link

bors bot commented May 24, 2022

Build failed:

@morenol
Copy link
Contributor

morenol commented May 24, 2022

bors r+

bors bot pushed a commit that referenced this pull request May 24, 2022
Fix typo in `fluvio_types::event::offsets::OffsetPublisher`:

* deprecate `change_listner`
* replace by `change_listener`


Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>
@bors
Copy link

bors bot commented May 24, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Fix some typo Event change_listener [Merged by Bors] - Fix some typo Event change_listener May 24, 2022
@bors bors bot closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants