Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #2355

Closed
wants to merge 1 commit into from
Closed

Fix some typos #2355

wants to merge 1 commit into from

Conversation

ilaborie
Copy link
Contributor

@ilaborie ilaborie commented May 9, 2022

While looking at the code, I saw some typos, this PR is just to correct them.
I didn't see any rules about deprecations, so here are the choices I made:

  • I corrected typos in the comments, including in the changelog.
  • for the code, I tried to preserve the api by using #[deprecated]
  • for crates/fluvio-cli/src/topic/create.rs I did not put the #[deprecated] because the CreateTopicOpt is created by the clap parser
  • for crates/fluvio-dataplane-protocol/src/error_code.rs because two variants can't share the same tag (derive Encoder/Decoder)
  • Be careful with crates/fluvio-sc/src/k8/controllers/mod.rs, I don't know the consequences of the correction

Also I don't know if I should rename crates/fluvio-protocol/src/core/varint.rs to variant.rs?

@sehz
Copy link
Contributor

sehz commented May 9, 2022

Good catch. Thanks

@github-actions
Copy link

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants