Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use version from the client in SmartEngine to encode/decode input/output #1924

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Use version from the client in SmartEngine to encode/decode input/output #1924

wants to merge 7 commits into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Nov 19, 2021 •
edited
Loading

Closes #1894

Backward compatibility with old wasm modules is keep due to we now check for both

 TypedFunc<(i32, i32), i32>;
 TypedFunc<(i32, i32, u32), i32>;

@morenol morenol force-pushed the lmm/aggregate_issue branch 6 times, most recently from 1a115f9 to 792736e Compare November 19, 2021 20:16
@morenol morenol changed the title Lmm/aggregate issue Use version from the client in SmartEngine to encode/decode input/output Nov 20, 2021
@morenol morenol marked this pull request as ready for review November 20, 2021 03:15
@morenol morenol requested a review from sehz November 20, 2021 03:16
sehz
sehz approved these changes Nov 20, 2021
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@sehz
Copy link
Contributor

sehz commented Nov 20, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 20, 2021
@morenol
Use version from the client in SmartEngine to encode/decode input/out…
cd7a0cf 
…put (#1924)

Closes #1894

Backward compatibility with old wasm modules is keep due to we now check for both 
```rust
 TypedFunc<(i32, i32), i32>;
 TypedFunc<(i32, i32, u32), i32>;
```
@bors
Copy link

bors bot commented Nov 20, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Use version from the client in SmartEngine to encode/decode input/output [Merged by Bors] - Use version from the client in SmartEngine to encode/decode input/output Nov 20, 2021
@bors bors bot closed this Nov 20, 2021
@morenol morenol deleted the lmm/aggregate_issue branch November 20, 2021 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SmartStream aggregate for version 0.3.0 doesn't work for current version
2 participants
@morenol @sehz