[Merged by Bors] - Report error to client when SPU is given invalid WASM module #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
requested changes
Oct 1, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
Closes #1143. When supplying an invalid WASM module to the consumer, the client will now return with the following error: ``` $ flvd consume fruits -B --filter=Cargo.toml # note that Cargo.toml is not a valid WASM file Consuming records starting 10 from the end of topic 'fruits' Error: 0: Fluvio client error 1: SmartStream error 2: WASM Module error: failed to parse WebAssembly module ``` Action items: - [x] Implement error delivery - [x] Add integration test
|
Build failed: |
|
Oh interesting, I didn't actually know what the crate_version check did until now! Cool catch, and nice script @tjtelan! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 2, 2021
Closes #1143. When supplying an invalid WASM module to the consumer, the client will now return with the following error: ``` $ flvd consume fruits -B --filter=Cargo.toml # note that Cargo.toml is not a valid WASM file Consuming records starting 10 from the end of topic 'fruits' Error: 0: Fluvio client error 1: SmartStream error 2: WASM Module error: failed to parse WebAssembly module ``` Action items: - [x] Implement error delivery - [x] Add integration test
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1143.
When supplying an invalid WASM module to the consumer, the client will now return with the following error:
Action items: