Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add progress indicator to fluvio cluster --k8 command #1627

Closed
wants to merge 4 commits into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Sep 14, 2021

Fixes #1635
Fixes #1636

@morenol morenol marked this pull request as ready for review September 15, 2021 19:08
@morenol morenol changed the title Add progress indicator to fluvio cluster --k8 --setup command Add progress indicator to fluvio cluster --k8 command Sep 21, 2021
@morenol morenol requested a review from sehz September 21, 2021 18:45
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating SPU managed group should behave like in the local cluster. Currently it doesn't show right progress bar.

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to add changelog

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@sehz
Copy link
Contributor

sehz commented Sep 21, 2021

bors r+

bors bot pushed a commit that referenced this pull request Sep 21, 2021
@bors
Copy link

bors bot commented Sep 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Add progress indicator to fluvio cluster --k8 command [Merged by Bors] - Add progress indicator to fluvio cluster --k8 command Sep 21, 2021
@bors bors bot closed this Sep 21, 2021
@morenol morenol deleted the lmm/k8-progress branch November 5, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants