-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Upgrade to new wasmtime API #1219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for migration efforts. Few questions....
9928e65
to
78b836c
Compare
@sehz any other questions on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep existing API much as possible.
also add to CHANGELOG.
6b722c8
to
4495291
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
bors r+ |
Closes #1200 This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
Build failed: |
bors r+ |
Closes #1200 This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
Build failed: |
bors r+ |
Closes #1200 This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
4495291
to
d1ca6bb
Compare
Canceled. |
bors r+ |
Closes #1200 This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
Build failed: |
4d0f032
to
471eb44
Compare
bors r+ |
Closes #1200 This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
Pull request successfully merged into master. Build succeeded: |
Oh it worked, woohoo! 🎉 |
Closes #1200
This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work