Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Upgrade to new wasmtime API #1219

Closed

Conversation

nicholastmosher
Copy link
Contributor

@nicholastmosher nicholastmosher commented Jul 9, 2021

Closes #1200

This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work

@nicholastmosher nicholastmosher requested a review from sehz July 9, 2021 19:25
@sehz sehz linked an issue Jul 9, 2021 that may be closed by this pull request
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migration efforts. Few questions....

src/spu/src/smart_stream/filter.rs Outdated Show resolved Hide resolved
src/spu/src/smart_stream/memory.rs Show resolved Hide resolved
src/spu/src/smart_stream/mod.rs Show resolved Hide resolved
src/spu/src/smart_stream/mod.rs Show resolved Hide resolved
@nicholastmosher
Copy link
Contributor Author

@sehz any other questions on this?

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep existing API much as possible.
also add to CHANGELOG.

src/spu/src/services/public/stream_fetch.rs Outdated Show resolved Hide resolved
src/spu/src/services/public/stream_fetch.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sehz
Copy link
Contributor

sehz commented Jul 12, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 12, 2021
Closes #1200 

This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
@bors
Copy link

bors bot commented Jul 12, 2021

Build failed:

@sehz
Copy link
Contributor

sehz commented Jul 12, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 12, 2021
Closes #1200 

This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
@bors
Copy link

bors bot commented Jul 12, 2021

Build failed:

@nicholastmosher
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 12, 2021
Closes #1200 

This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
@bors
Copy link

bors bot commented Jul 12, 2021

Canceled.

@nicholastmosher
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 12, 2021
Closes #1200 

This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
@bors
Copy link

bors bot commented Jul 12, 2021

Build failed:

@nicholastmosher
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 12, 2021
Closes #1200 

This upgrades to the new Wasmtime API that better supports Send + Sync and multithreaded environments. This should make it easier to finish up other smartstream work
@bors
Copy link

bors bot commented Jul 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Upgrade to new wasmtime API [Merged by Bors] - Upgrade to new wasmtime API Jul 12, 2021
@bors bors bot closed this Jul 12, 2021
@nicholastmosher nicholastmosher deleted the wasmtime-upgrade branch July 12, 2021 19:30
@nicholastmosher
Copy link
Contributor Author

Oh it worked, woohoo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPU: upgrade to Wasmtime 0.28.0
2 participants