[Merged by Bors] - feat: generic implementation of tokio_util::codec::Encoder for FluvioEncoder #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
force-pushed
the
lmm/fluviocodec
branch
2 times, most recently
from
0c669ab
to
83020e4
Compare
morenol
changed the title
morenol
commented
May 13, 2021
morenol
commented
May 13, 2021
|
@morenol is this ready for review then? |
sehz
requested changes
May 13, 2021
|
@simlay Can you test if your websocket works with this? You should be able to remove work around for 4 bytes issue |
morenol
commented
May 13, 2021
morenol
force-pushed
the
lmm/fluviocodec
branch
8 times, most recently
from
0ad49ba
to
62d78e0
Compare
|
This looks great! @simlay This is ready. Can you test your websocket changes with this? However, there is problem with codec's version change since it is exported by wrapper crate. There are 2 ways we can solve this:
|
|
Nice! In that case, you don't have to bump up major version for codec. Just change to |
sehz
requested changes
May 13, 2021
sehz
reviewed
May 13, 2021
|
can you rebase from master to changes by @simlay ? |
…ric FluvioEncoder instead of raw bytes. feat: make encoder-decoder of RequestMessage and ResponseMessage symmetric feat: change decode_from_file implementation of ApiMessage to ignore data lenght since it is not present in the encoding. test: added test for the cases where it is being used tokio_util::codec::Encoder<T: FluvioEncoder> build: bump fluvio-protocol-api
|
@simlay can you try now? |
sehz
requested changes
May 14, 2021
|
go thru all users of |
sehz
approved these changes
May 14, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 14, 2021
…Encoder (#1081) Fixes #1075 * Changes the implementation of ResponseMessage and RequestMessage encoder to not include their lengths so the encode-decoder is symmetric now. * * Added to `FluvioCodec` the capability to handle `FluvioEncoder` types. * Add implementations of FluvioEncoder to &T: FluvioEncoder.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1075
Changes the implementation of ResponseMessage and RequestMessage encoder to not include their lengths so the encode-decoder is symmetric now.
Added to
FluvioCodecthe capability to handleFluvioEncodertypes.Add implementations of FluvioEncoder to &T: FluvioEncoder.