Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Relax platform version requirement for upgrade check #1055

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Relax platform version requirement for upgrade check #1055

wants to merge 5 commits into from

Conversation

nicholastmosher
Copy link
Contributor

Closes #1054.

  • Now compares expected platform version to actual platform version using just major.minor.patch version components
  • Should prevent upgrade error when using a "latest" platform version including a commit hash

sehz
sehz requested changes May 5, 2021
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I don't see any test associated with it?

nacardin
nacardin approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@nacardin nacardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works

@sehz
Copy link
Contributor

sehz commented May 5, 2021

doc test is failing

sehz
sehz approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Not sure about testing version checking?

@nicholastmosher
Copy link
Contributor Author

@sehz I extracted the version checking into a function and added some tests 👍

@nicholastmosher
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request May 6, 2021
@nicholastmosher
Relax platform version requirement for upgrade check (#1055)
e2f743a 
Closes #1054.

- Now compares expected platform version to actual platform version using just `major.minor.patch` version components
- Should prevent upgrade error when using a "latest" platform version including a commit hash
@bors
Copy link

bors bot commented May 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Relax platform version requirement for upgrade check [Merged by Bors] - Relax platform version requirement for upgrade check May 6, 2021
@bors bors bot closed this May 6, 2021
@nicholastmosher nicholastmosher deleted the relax-version branch May 6, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

@nacardin nacardin nacardin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relax platform version comparision
3 participants
@nicholastmosher @sehz @nacardin