chore: default to zigbuild for cross-compilation #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe we should convert default build to use |
Lets try that! |
EstebanBorai
changed the title
EstebanBorai
changed the title
digikata
approved these changes
Jul 16, 2024
sehz
reviewed
Jul 18, 2024
I don't think so, I believe zigbuild only replaces linker, not CC. |
|
got it |
sehz
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on building the Fluvio image to run in Kubernetes on macOS I found that
cross-compilation of Fluvio might have some incompatibility issues.
In order to speed up development I ended up using
zigbuildas an alternative to cross-compile Fluvio.In the future, perhaps it would be nice to detect host's OS and conditionally use
zigbuildif running onmacOSfor such step.