Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo_template Cargo.toml noise #3919

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

digikata
Copy link
Contributor

fixes #3914

Copy link
Contributor

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@digikata digikata enabled auto-merge March 27, 2024 00:54
@digikata digikata added this pull request to the merge queue Mar 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 27, 2024
@morenol morenol added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit ee75fdf Mar 27, 2024
102 checks passed
@morenol morenol deleted the ac/fix-cargo-templates branch March 27, 2024 14:58
@pinkforest
Copy link
Contributor

fyi anything that points to the release git tag is broken atm - either a new release or back-port would be good perhaps ?

@ajhunyady
Copy link
Contributor

@digikata, why are we pointing to a git tag?

@pinkforest
Copy link
Contributor

pinkforest commented Apr 14, 2024

Problem with pinning to revision is that things get out of date and don't get updates e.g. patches / bug fixes

Ideally these should be available via package manager - I agree.

By using tag it uses it in SemVer basis and ensures compatibility within same SemVer whilst getting updates

Also rev was used before this changed to tags - see this review comment when I used rev as it was used before:

The decision was here to use tag ref:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo templates causes errors in cargo checks when projects reference the fluvio repo
5 participants