Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: deprecatefluvio install #3655

Closed

Conversation

EstebanBorai
Copy link
Contributor

Deprecates fluvio install to use fvm install instead.

@EstebanBorai EstebanBorai marked this pull request as ready for review November 2, 2023 18:54
@EstebanBorai
Copy link
Contributor Author

@tjtelan I added a deprecation notice on fluvio install as we move into fvm install instead.

Do you have any recommendations on a documentation link to point to as part of the warning message?

As we release this on 0.11.0 users could visit FVM section in the docs to read more.

Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +55 to +56
println!("warning: `fluvio install` is deprecated, use `fvm install` instead.");
println!("Refer to https://www.fluvio.io/docs/get-started/linux/#install-fluvio-cli");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds deprecation notice and link to install docs.

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 2, 2023
Deprecates `fluvio install` to use `fvm install` instead.
Copy link

bors bot commented Nov 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: deprecatefluvio install [Merged by Bors] - feat: deprecatefluvio install Nov 2, 2023
@bors bors bot closed this Nov 2, 2023
vrrashkov pushed a commit to vrrashkov/fluvio that referenced this pull request Nov 3, 2023
Deprecates `fluvio install` to use `fvm install` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants