-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: remove unnecessary generics #3529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
reviewed
Sep 13, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
convert many generic based argument conversion like `<S: Into<String>>` into `impl Into<String>`. This remove unnecessary generic signature and hopefully reduce build time and make code cleaner
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
chore: remove unnecessary generics
[Merged by Bors] - chore: remove unnecessary generics
Sep 15, 2023
bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Revert unnecessary bump up of fluvio #3529. There was no of release 0.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert many generic based argument conversion like
<S: Into<String>>
intoimpl Into<String>
. This remove unnecessary generic signature and hopefully reduce build time and make code cleaner