Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update fluvio hub subcommands #3409

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Update fluvio hub subcommands #3409

wants to merge 3 commits into from

Conversation

tjtelan
Copy link
Contributor

@tjtelan tjtelan commented Jul 21, 2023

Resolves #3187

Make experience with smartmodules and connectors consistent with each other with list and download commands

Be consistent with the `connector` flags
Using a published connector name (except for version)
@tjtelan tjtelan requested a review from digikata July 21, 2023 16:52
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjtelan
Copy link
Contributor Author

tjtelan commented Jul 22, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 22, 2023
Resolves #3187 

Make experience with smartmodules and connectors consistent with each other with `list` and `download` commands
@bors
Copy link

bors bot commented Jul 22, 2023

Build failed:

@ajhunyady
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Aug 9, 2023
Resolves #3187 

Make experience with smartmodules and connectors consistent with each other with `list` and `download` commands
@bors
Copy link

bors bot commented Aug 9, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Update fluvio hub subcommands [Merged by Bors] - Update fluvio hub subcommands Aug 9, 2023
@bors bors bot closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

address usability issues with hub, cdk and smdksmartmodule
3 participants