[Merged by Bors] - Unify common dependencies #3408
Conversation
|
Hi @c410-f3r! I think we have to bump patch on |
|
Thank you @EstebanBorai |
connector/cargo_template/Cargo.toml
Outdated
| @@ -7,4 +7,4 @@ edition = "2021" | |||
| [dependencies] | |||
| fluvio = { git = "https://github.com/infinyon/fluvio", rev = "{{fluvio-cargo-dependency-hash}}" } | |||
| fluvio-connector-common = { git = "https://github.com/infinyon/fluvio", rev = "{{fluvio-cargo-dependency-hash}}", features = ["derive"]} | |||
| serde = { version = "1.0", default-features = false, features = ["derive"]} | |||
| serde = { default-features = false, features = ["derive"], workspace = true } | |||
There was a problem hiding this comment.
templates can't have workspace dependency since they will be deployed outside fluvio repo
|
Hi @c410-f3r! Thanks for the time and effort invested in this PR! |
Oh, thank you for the heads up! The conflicting file has been fixed. |
Thanks to you!! |
|
Looks like |
|
bors r+ |
There is a considerable amount of dependencies and I think it is possible to cut some transient slack in order to reduce compilation time. Starting with the unification of common dependencies that aren't part of workspace declarations. `cargo test --all-features` didn't fail so everything should probably be OK.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Continuation of #3408 To the best of my knowledge, all common dependencies are now sharing the same workspace definition.
Continuation of #3408 To the best of my knowledge, all common dependencies are now sharing the same workspace definition. Co-authored-by: morenol <22335041+morenol@users.noreply.github.com>
Continuation of #3408 To the best of my knowledge, all common dependencies are now sharing the same workspace definition. Co-authored-by: morenol <22335041+morenol@users.noreply.github.com>
There is a considerable amount of dependencies and I think it is possible to cut some transient slack in order to reduce compilation time.
Starting with the unification of common dependencies that aren't part of workspace declarations.
cargo test --all-featuresdidn't fail so everything should probably be OK.