-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(smdk): support lookback
in test
#3317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add CLI test?
added in d1d962a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
bors r+ |
Added an ability to specify the lookback parameter and provide existing records to simulate data in the topic. For example, here we run `test` and pass input record "1" and provide other records "2" and "3" as they would exist in the topic before: ```bash smdk test --text "1" --lookback-last 1 --record "2" --record "3" ``` the `look_back` function will receive record "3". Closes #3315
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
lookback
in testlookback
in test
Added an ability to specify the lookback parameter and provide existing records to simulate data in the topic.
For example, here we run
test
and pass input record "1" and provide other records "2" and "3" as they would exist in the topic before:the
look_back
function will receive record "3".Closes #3315