Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(smdk): support lookback in test #3317

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(smdk): support lookback in test #3317

wants to merge 2 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Jun 8, 2023

Added an ability to specify the lookback parameter and provide existing records to simulate data in the topic.

For example, here we run test and pass input record "1" and provide other records "2" and "3" as they would exist in the topic before:

smdk test --text "1" --lookback-last 1 --record "2" --record "3" 

the look_back function will receive record "3".

Closes #3315

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add CLI test?

@galibey
Copy link
Contributor Author

galibey commented Jun 9, 2023

Can we add CLI test?

added in d1d962a

Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@galibey
Copy link
Contributor Author

galibey commented Jun 9, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 9, 2023
Added an ability to specify the lookback parameter and provide existing records to simulate data in the topic.

For example, here we run `test` and pass input record "1" and provide other records "2" and "3" as they would exist in the topic before:
```bash
smdk test --text "1" --lookback-last 1 --record "2" --record "3" 
```
the `look_back` function will receive record "3".

Closes #3315
@bors
Copy link

bors bot commented Jun 9, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • Done

@bors bors bot changed the title feat(smdk): support lookback in test [Merged by Bors] - feat(smdk): support lookback in test Jun 9, 2023
@bors bors bot closed this Jun 9, 2023
@galibey galibey deleted the feat/3315-add-lookback-to-smdk branch June 9, 2023 14:44
@sehz sehz added this to the 0.10.11 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of lock_back to SMDK tool
2 participants