[Merged by Bors] - feat: fail fast if socket is stale #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
commented
Mar 7, 2023
| /// send and wait for reply serially | ||
| #[instrument(level = "trace", skip(self, request))] | ||
| pub async fn send_receive<R>(&self, request: R) -> Result<R::Response, SocketError> | ||
| where | ||
| R: Request + Send + Sync, | ||
| { | ||
| if self.is_stale() { | ||
| return Err(SocketError::SocketStale); |
There was a problem hiding this comment.
We should handle this on Fluvio and FluvioAdmin and call reconnect if happens
morenol
changed the title
sehz
requested changes
Mar 7, 2023
| /// send and wait for reply serially | ||
| #[instrument(level = "trace", skip(self, request))] | ||
| pub async fn send_receive<R>(&self, request: R) -> Result<R::Response, SocketError> | ||
| where | ||
| R: Request + Send + Sync, | ||
| { | ||
| if self.is_stale() { | ||
| return Err(SocketError::SocketStale); |
| /// send and wait for reply serially | ||
| #[instrument(level = "trace", skip(self, request))] | ||
| pub async fn send_receive<R>(&self, request: R) -> Result<R::Response, SocketError> | ||
| where | ||
| R: Request + Send + Sync, | ||
| { | ||
| if self.is_stale() { | ||
| return Err(SocketError::SocketStale); |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2023
Right now if socket is stale, we get this error after 300 seconds:
```
Io {
source: Custom {
kind: TimedOut,
error: "Timed out: 300 secs waiting for response. API_KEY=1003, CorrelationId=27",
},
msg: "",
},
```
This fail fast is a socket stale is detected.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if socket is stale, we get this error after 300 seconds:
This fail fast is a socket stale is detected.