[Merged by Bors] - feat: remove secrets and parameters from connector meta config #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
approved these changes
Feb 27, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
1. Removed `secrets` and `parameters` from `MetaConfig` as they aren't used in the new Connectors SDK. 2. Secrets moved from `fluvio-connector-common` crate to `fluvio-connector-package` where it is initially planned to be. 3. Added detection of used inside the config file secrets for validation or other places where we will need the list of used secrets (for example, before mounting to the container).
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
1. Removed `secrets` and `parameters` from `MetaConfig` as they aren't used in the new Connectors SDK. 2. Secrets moved from `fluvio-connector-common` crate to `fluvio-connector-package` where it is initially planned to be. 3. Added detection of used inside the config file secrets for validation or other places where we will need the list of used secrets (for example, before mounting to the container).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secretsandparametersfromMetaConfigas they aren't used in the new Connectors SDK.fluvio-connector-commoncrate tofluvio-connector-packagewhere it is initially planned to be.