Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: added sink connector support to SDK #2906

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: added sink connector support to SDK #2906

wants to merge 1 commit into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Dec 28, 2022

Added initial support for #[connector(sink)] to Connector SDK and an example of usage.

Fixes #2884

@galibey galibey self-assigned this Dec 28, 2022
@galibey galibey added this to the 0.10.4 milestone Dec 28, 2022
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and clean!

Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@galibey
Copy link
Contributor Author

galibey commented Dec 28, 2022

bors r+

bors bot pushed a commit that referenced this pull request Dec 28, 2022
Added initial support for `#[connector(sink)]` to Connector SDK and an example of usage.

Fixes #2884
@bors
Copy link

bors bot commented Dec 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: added sink connector support to SDK [Merged by Bors] - feat: added sink connector support to SDK Dec 28, 2022
@bors bors bot closed this Dec 28, 2022
@galibey galibey deleted the feat/add-sink-derive-connector branch December 28, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Sink Connector in Connectors SDK
3 participants