Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clap and clap_complete crates #2633

Closed
morenol opened this issue Sep 29, 2022 · 0 comments
Closed

Update clap and clap_complete crates #2633

morenol opened this issue Sep 29, 2022 · 0 comments
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers help wanted Good issue for community involvement

Comments

@morenol
Copy link
Contributor

morenol commented Sep 29, 2022

It looks like there is a new release for those crates and automatic PR from dependabot failed to compile

#2628
#2629

We need to check the changelog for the new release and update accordingly
@morenol morenol added help wanted Good issue for community involvement good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Sep 29, 2022
@morenol morenol mentioned this issue Sep 29, 2022
Closed
@NiceneNerd NiceneNerd mentioned this issue Oct 10, 2022
Closed
@bors bors bot closed this as completed in 28601cf Oct 15, 2022
davidbeesley pushed a commit to davidbeesley/fluvio that referenced this issue Oct 31, 2022
@NiceneNerd @davidbeesley
refactor: Update clap to v4 (infinyon#2670)
3792e14 
Closes infinyon#2633, which was slightly more labyrinthine than it perhaps first appeared. Nonetheless, nothing too troublesome. It passes a great deal of test and CI stuff, but since I am new to fluvio (and only slightly familiar with clap) I admit I could be missing something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers help wanted Good issue for community involvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - refactor: Update clap to v4 NiceneNerd/fluvio-1
1 participant
@morenol