Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix crate publish readiness check #2550

Closed
tjtelan opened this issue Aug 11, 2022 · 1 comment
Closed

[CI] Fix crate publish readiness check #2550

tjtelan opened this issue Aug 11, 2022 · 1 comment
Labels
bug Something isn't working CI good first issue Good for newcomers help wanted Good issue for community involvement technical debt Test Infrastructure Testing infrastructure

Comments

@tjtelan
Copy link
Contributor

tjtelan commented Aug 11, 2022

This CI run had a false positive:
https://github.com/infinyon/fluvio/runs/7687135285?check_suite_focus=true

This test should have failed:
https://github.com/infinyon/fluvio/blob/master/.github/workflows/ci.yml#L297-L298

Which eventually resulted in a cargo publish job failing:
https://github.com/infinyon/fluvio/runs/7778435436?check_suite_focus=true

The cause was due to a path dependency update where the version number of the crate was removed.

This fine for development, since the build is unaffected. But the steps during the publish build is different. The Cargo book says that crates with path dependencies can't be published. The paths are ignored and cargo falls back on the public crate version.

So it seems we're exposed to this only when we are updating crates, after Bors has merged. It isn't an obvious thing to spot in a PR.
@tjtelan tjtelan added bug Something isn't working help wanted Good issue for community involvement good first issue Good for newcomers technical debt CI Test Infrastructure Testing infrastructure labels Aug 11, 2022
@xenago xenago mentioned this issue Aug 24, 2022
Closed
bors bot pushed a commit that referenced this issue Aug 25, 2022
@xenago
test: add check for pinned versions (#2589)
415c3e5 
Validate that crates with [multiple locations](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations) defined have a version specified/pinned.

When replicating the problem described in #2550 (removing the pinned version for `fluvio-package-index` in the `Cargo.toml` for `fluvio-extension-common`), the test now fails with a relevant error message:
![image](https://user-images.githubusercontent.com/11216007/186537222-808fde56-8828-4287-a4f2-b8ac207b260c.png)
@tjtelan tjtelan mentioned this issue Aug 25, 2022
Closed
@tjtelan tjtelan linked a pull request Aug 26, 2022 that will close this issue
[Merged by Bors] - test: add check for pinned versions #2589
Closed
@tjtelan
Copy link
Contributor Author

tjtelan commented Aug 26, 2022

Closed by #2589

@tjtelan tjtelan closed this as completed Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI good first issue Good for newcomers help wanted Good issue for community involvement technical debt Test Infrastructure Testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - test: add check for pinned versions
1 participant
@tjtelan