[Merged by Bors] - Initial stuff for Fluvio::connect_with_connector #1120
Conversation
|
rustfmt is failing |
|
local cluster test is failing |
"Expected browser binary location, but unable to find binary in default location, no 'moz:firefoxOptions.binary' capability provided, and no binary flag set on the command line" @nacardin is firefox or chrome installed on the custom runner? |
|
Suggest separating integration test as 2nd PR so code changes can go thru |
| pub async fn connect_with_connector( | ||
| connector: DomainConnector, | ||
| config: &FluvioConfig, | ||
| ) -> Result<Self, FluvioError> { |
There was a problem hiding this comment.
Why are we adding this? And more importantly, what is the usage pattern here? Are we expecting typical users to leverage this or is it more of an implementation detail for the WASM library that users will not directly use?
| let producer = client.topic_producer(topic.clone()).await; | ||
| assert!(producer.is_ok()); | ||
| let producer = producer.unwrap(); | ||
| let send = producer.send("foo", "bar").await; |
There was a problem hiding this comment.
This is a work around because #986 is still an issue.
|
will merge this after release |
|
bors r+ |
I also added in a wasm test. I've got mixed feelings about where it is now.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
|
Move changelog for this to 0.8.4 |
I also added in a wasm test. I've got mixed feelings about where it is now.