Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax platform version comparision #1054

Closed
nicholastmosher opened this issue May 5, 2021 · 0 comments
Closed

Relax platform version comparision #1054

nicholastmosher opened this issue May 5, 2021 · 0 comments
Assignees
Milestone

Comments

@nicholastmosher
Copy link
Contributor

We have logic in the client library to check whether the cluster it has connected to meets a set minimum version. This is in order to make sure that the components that are communicating have the same protocol, etc. However, this version checking is being too specific, which is causing breakages when we are testing out "latest" builds:

Existing platform version is different than chart version platform=0.8.1 chart_version=0.8.1-f78f77f947886b894268f9918a369db1aefe1cd6

We should relax the version comparison logic to only check the major.minor.patch version compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants