Skip to content

Commit

Permalink
Change chart location for local installer (#1675)
Browse files Browse the repository at this point in the history
Fixes #1647

Running `helm install fluvio-sys ./k8-util/helm/` fails with 
```
Error: validation: chart.metadata is required
```
`helm install fluvio-sys ./k8-util/helm/fluvio-sys` works
  • Loading branch information
morenol committed Sep 22, 2021
1 parent 251d995 commit 485775c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Platform Version 0.9.8 - UNRELEASED
* Add progress indicator to `fluvio cluster start` ([#1627](https://github.com/infinyon/fluvio/pull/1627))
* Added `fluvio cluster diagnostics` to help debugging with support ([#1671](https://github.com/infinyon/fluvio/pull/1671))
* Fix installation of sys charts when running `fluvio cluster start --local --develop` ([#1647](https://github.com/infinyon/fluvio/issues/1647))

## Platform Version 0.9.7 - 2021-09-16
* Improve progress message in `fluvio cluster start --local` ([#1586](https://github.com/infinyon/fluvio/pull/1586))
Expand Down
2 changes: 1 addition & 1 deletion crates/fluvio-cluster/src/check/render.rs
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ impl ProgressRenderedText for CheckStatus {
None => "".to_string(),
};
let msg = format!("{}{}", e, cause);
format!("{:>6} {}", "❌".bold(), msg.red())
format!("{:>6} {}", "❌", msg.red())
}
};

Expand Down
10 changes: 2 additions & 8 deletions crates/fluvio-cluster/src/cli/start/local.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,8 @@ pub async fn process_local(
.render_checks(true)
.spu_replicas(opt.spu);

match opt.k8_config.chart_location {
Some(chart_location) => {
builder.local_chart(chart_location);
}
None if opt.develop => {
builder.local_chart("./k8-util/helm");
}
_ => (),
if let Some(chart_location) = opt.k8_config.chart_location {
builder.local_chart(chart_location);
}

if let Some(rust_log) = opt.rust_log {
Expand Down

0 comments on commit 485775c

Please sign in to comment.