Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced borderSide attribute with border attribute in BarChartRodData #1349

Closed
wants to merge 15 commits into from
Closed

Replaced borderSide attribute with border attribute in BarChartRodData #1349

wants to merge 15 commits into from

Conversation

MagdyYacoub1
Copy link
Contributor

Resolve issue #1194

Replaced borderSide attribute with border attribute in BarChartRodData

This enables specifying each border side separately.

@codecov
Copy link

codecov bot commented May 28, 2023 •
edited
Loading

Codecov Report

Merging #1349 (2f6fb8e) into master (478e5e6) will increase coverage by 0.31%.
The diff coverage is 93.90%.

❗ Current head 2f6fb8e differs from pull request most recent head 8ec7e70. Consider uploading reports for the commit 8ec7e70 to get more accurate results

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   86.09%   86.41%   +0.31%     
==========================================
  Files          45       45              
  Lines        2978     3054      +76     
==========================================
+ Hits         2564     2639      +75     
- Misses        414      415       +1
Impacted Files Coverage Δ
lib/src/chart/bar_chart/bar_chart_painter.dart 93.36% <93.42%> (+1.18%) ⬆️
lib/src/utils/utils.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 8, 2023

I think you need to write some unit-tests

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 8, 2023

But your code is approved!

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 14, 2023

It seems there are some conflicts, please rebase your branch again

@MagdyYacoub1
Copy link
Contributor Author

I'm sorry for not getting back to you sooner, but I was away for the past two weeks.

I resolved the conflicts. please, try again now.

@MagdyYacoub1 MagdyYacoub1 reopened this Jun 22, 2023
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 6, 2023

Hi, sorry for my late response. There are new conflicts.
It would be great if you fix them again.
Thanks!

@MagdyYacoub1
Updated BarChartRodData to get border attribute of type Border instea…
f84a479 
…d of BorderSide

updated bar_chart_painter.dart
Added normalizeBorder function and defaultBorder attribute in utils.dart
@MagdyYacoub1
Updated examples
49c0034
@MagdyYacoub1
Updated tests
7dcc903
@MagdyYacoub1
Added assert statement with comment how to solve the error.
40a62cb 
Updated painter so the paint method be more constant with the paint method in the framework
@MagdyYacoub1
Update CHANGELOG.md.
d3d0315 
Update documentation.
Remove format warning
@MagdyYacoub1
Added some unit-tests to bar_chart_painter_test.dart
a5ddae0
@MagdyYacoub1
Resolved conflicts.
ddcb1f6
@MagdyYacoub1
Update CHANGELOG.md.
f9c01bc 
Update documentation.
Remove format warning
@MagdyYacoub1
Added some unit-tests to bar_chart_painter_test.dart
0c01d7a
@MagdyYacoub1
Updated BarChartRodData to get border attribute of type Border instea…
0d86e76 
…d of BorderSide

updated bar_chart_painter.dart
Added normalizeBorder function and defaultBorder attribute in utils.dart
@MagdyYacoub1
Added assert statement with comment how to solve the error.
15a2572 
Updated painter so the paint method be more constant with the paint method in the framework
@MagdyYacoub1
Update CHANGELOG.md.
10238ca 
Update documentation.
Remove format warning
@MagdyYacoub1
Added some unit-tests to bar_chart_painter_test.dart
98cda6c
@MagdyYacoub1
Added assert statement with comment how to solve the error.
602c82e 
Updated painter so the paint method be more constant with the paint method in the framework
@MagdyYacoub1
Update CHANGELOG.md.
8ec7e70 
Update documentation.
Remove format warning
@MagdyYacoub1
Copy link
Contributor Author

I resolved recent conflicts. Please provide me with some insights on why these conflicts happen so I can avoid that in the future.
Thanks in advance. @imaNNeo

imaNNeo
imaNNeo reviewed Jul 31, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@imaNNeo
Copy link
Owner

imaNNeo commented Jul 31, 2023 •
edited
Loading

There is an issue with BarSample 5
Please check it out, It will not happen in the master branch.
But it happens in your branch.
I am on mac with the latest version of flutter
(There might be an issue with the canvas in your changes)

bar.5.issue.mov

@imaNNeo
Copy link
Owner

imaNNeo commented Jul 31, 2023

I resolved recent conflicts. Please provide me with some insights on why these conflicts happen so I can avoid that in the future. Thanks in advance. @imaNNeo

Because we are constantly update the master branch (by pushing new commits). So you need to update your branch with the master.
The best way to do that is rebasing. Please read our contributing guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imaNNeo imaNNeo imaNNeo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MagdyYacoub1 @imaNNeo