Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abilit to specify a border with different border sides for bar charts. #1194

Open
dgriffith0 opened this issue Dec 19, 2022 · 2 comments
Open
Labels
Bar Chart enhancement New feature or request good first issue Good for newcomers

Comments

@dgriffith0
Copy link

Currently BarChartRodData only takes a BorderSide and the choices are a full border or no border.

I need to be able to specify a top border only.

@imaNNeo imaNNeo added enhancement New feature or request good first issue Good for newcomers Bar Chart labels Jan 15, 2023
@MagdyYacoub1
Copy link
Contributor

I'm intending to work on this issue.
My approach for it is to replace borderSide attribute with another attribute of type Border. This will give the ability to specify each side independently.
This will lead to the possibility of having non-uniform borders. This type of border works when there is no border-radius specified. In other words, the bar is rectangular in shape.
if the bar is a rounded rectangle the borders must be of type uniform borders which can be specified by Border.all() or Border.fromBorderSide().

@imaNNeo

@imaNNeo
Copy link
Owner

imaNNeo commented Apr 30, 2023

Hi @MagdyYacoub1

You are exactly correct, do that :)

btw, Flutter does the same about the border radius and non-uniform borders, it throws an exception,
You can check their logic and do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bar Chart enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants