Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unreachable code #167

Closed
sebastian-peter opened this issue Mar 7, 2022 · 0 comments · Fixed by #171
Closed

Fix unreachable code #167

sebastian-peter opened this issue Mar 7, 2022 · 0 comments · Fixed by #171
Assignees
@danielfeismann
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sebastian-peter
Copy link
Member

sebastian-peter commented Mar 7, 2022 •
edited
Loading

simona/src/main/scala/edu/ie3/simona/event/listener/ResultEventListener.scala

Lines 304 to 307 in 1d5dcb7

throw new InitializationException(
"Cannot initialize result sinks!"
).initCause(exception)
self ! PoisonPill

Introduced with #77. Statements have to be switched. Also, a test for this is required.

https://simona.ie3.e-technik.tu-dortmund.de/sonar/project/issues?id=edu.ie3%3Asimona&issues=AX5EWrTicE05oj4IaDLM&open=AX5EWrTicE05oj4IaDLM
@sebastian-peter sebastian-peter added bug Something isn't working good first issue Good for newcomers labels Mar 7, 2022
@danielfeismann danielfeismann self-assigned this Mar 8, 2022
@danielfeismann danielfeismann mentioned this issue Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unreachable code ie3-institute/simona
2 participants
@sebastian-peter @danielfeismann