Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null in toJSON if not valid #633

Merged
merged 3 commits into from
Jul 16, 2019
Merged

Return null in toJSON if not valid #633

merged 3 commits into from
Jul 16, 2019

Conversation

guillaumebriday
Copy link
Contributor

fixing #632

@codecov-io
Copy link

codecov-io commented Jul 16, 2019 •
edited
Loading

Codecov Report

Merging #633 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #633   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       154    154           
  Lines       986    986           
  Branches    141    142    +1     
===================================
  Hits        986    986
Impacted Files Coverage Δ
src/locale/pt-br.js 100% <ø> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef135e...ccecf4f. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Jul 16, 2019

Thanks, and unit test please.

@guillaumebriday
Copy link
Contributor Author

@iamkun Is it good ?

@iamkun iamkun merged commit 19affc8 into iamkun:dev Jul 16, 2019
@guillaumebriday
Copy link
Contributor Author

Thank you @iamkun !

iamkun pushed a commit that referenced this pull request Aug 27, 2019
@semantic-release-bot
chore(release): 1.8.16 [skip ci]
7241da9 
## [1.8.16](v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](a385d5c))
* Handle locale in WeekOfYear plugin ([#658](#658)) ([0e45b0a](0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](#645)) ([95e70b4](95e70b4))
* Return null in toJSON if not valid ([#633](#633)) ([19affc8](19affc8))
* Update Danish (da) locale ([#626](#626)) ([ac2ec77](ac2ec77))
* Update Korean locale meridiem ([#642](#642)) ([b457146](b457146))
* update Occitan locale Catalan locale ([#630](#630)) ([fef135e](fef135e))
* update pt-br locale ([#628](#628)) ([ccf596d](ccf596d))
* Update weekdaysShort to some locale files ([#643](#643)) ([cc1f15f](cc1f15f))
@iamkun
Copy link
Owner

iamkun commented Aug 27, 2019

🎉 This PR is included in version 1.8.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Mar 5, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.16 [skip ci]
629772c 
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c))
* Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4))
* Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8))
* Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77))
* Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146))
* update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e))
* update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d))
* Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.16 [skip ci]
5d4b611 
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c))
* Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4))
* Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8))
* Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77))
* Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146))
* update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e))
* update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d))
* Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.8.16 [skip ci]
3d3634d 
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([8a19114](iamkun/dayjs@8a19114))
* Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([bdda8b1](iamkun/dayjs@bdda8b1))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([9792adb](iamkun/dayjs@9792adb))
* Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([e146135](iamkun/dayjs@e146135))
* Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([bcf063b](iamkun/dayjs@bcf063b))
* Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([ea96cc1](iamkun/dayjs@ea96cc1))
* update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([66d2c7e](iamkun/dayjs@66d2c7e))
* update pt-br locale ([#628](iamkun/dayjs#628)) ([c3788a6](iamkun/dayjs@c3788a6))
* Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([02b270f](iamkun/dayjs@02b270f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guillaumebriday @codecov-io @iamkun