Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for breton language and implementation of mutations #1103

Merged
merged 10 commits into from
Oct 13, 2020
Merged

Tests for breton language and implementation of mutations #1103

merged 10 commits into from
Oct 13, 2020

Conversation

jbleduigou
Copy link
Contributor

Hi,

I have added the tests for the breton language.
Let me know anything needs to be modified.
I will happily do it 🙂

@codecov
Copy link

codecov bot commented Oct 1, 2020 •
edited
Loading

Codecov Report

Merging #1103 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines         1547      1567   +20     
  Branches       328       332    +4     
=========================================
+ Hits          1547      1567   +20
Impacted Files Coverage Δ
src/locale/br.js 100.00% <100.00%> (ø)
src/plugin/duration/index.js 100.00% <0.00%> (ø)
src/plugin/localeData/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1e426...b6b60a1. Read the comment docs.

@jbleduigou
🚨 fix linting: new line at end of file
4ccf894 
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou
🐛 fix incorrect relative times for breton
be59b24 
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou
Copy link
Contributor Author

This started as a fairly straightforward PR.
I actually discovered a bug in relative times.
Therefore I have also modified the code under test.

@jbleduigou
🙈 ignore the failing test, create an issue for it
0042b11 
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou
🙈 ignore the failing test, create an issue for it
0beb334 
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou
🙈 ignore the failing test, create an issue for it
8b3ffce 
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou
Copy link
Contributor Author

This PR already handles relative times for Breton languages.
However it is missing mutations.
I have created an issue for this : #1104

@jbleduigou
🐛 implement mutations for breton
07db6b7 
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou jbleduigou mentioned this pull request Oct 3, 2020
Closed
@jbleduigou
Copy link
Contributor Author

Added the full implementation of mutations

@jbleduigou
✅ add more tests and cleanup code
b6b60a1 
Signed-off-by: jbleduigou <jb.leduigou@gmail.com>
@jbleduigou jbleduigou changed the title Tests for breton language Tests for breton language and implementation of mutations Oct 3, 2020
@iamkun
Copy link
Owner

iamkun commented Oct 13, 2020

Thanks

@iamkun iamkun merged commit b038bfd into iamkun:dev Oct 13, 2020
iamkun pushed a commit that referenced this pull request Oct 13, 2020
@semantic-release-bot
chore(release): 1.9.2 [skip ci]
181c647 
## [1.9.2](v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](#1129)) ([be505c2](be505c2))
* export type of duration plugin ([#1094](#1094)) ([2c92e71](2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](#1101)) ([7937ccd](7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](#1107)) ([fe90bb6](fe90bb6)), closes [#1105](#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](#1108)) ([cc87eff](cc87eff))
* Fix typo for "monday" in arabic ([#1067](#1067)) ([2e1e426](2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](#1099)) ([b1a0294](b1a0294))
* update Breton [br] locale relativeTime config ([#1103](#1103)) ([b038bfd](b038bfd))
* update Catalan [ca] locale ordinal ([73da380](73da380))
* update German [de] locale relativeTime config ([#1109](#1109)) ([f6e771b](f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](#1106)) ([16937d1](16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](f56783e))
@iamkun
Copy link
Owner

iamkun commented Oct 13, 2020

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.2 [skip ci]
9c3b1b4 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.2 [skip ci]
cddaa78 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.9.2 [skip ci]
96b171e 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([185086c](iamkun/dayjs@185086c))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([0c62ed8](iamkun/dayjs@0c62ed8))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([fda168c](iamkun/dayjs@fda168c))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([9803fef](iamkun/dayjs@9803fef)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([45fe6b0](iamkun/dayjs@45fe6b0))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([6766d4a](iamkun/dayjs@6766d4a))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([a638ee6](iamkun/dayjs@a638ee6))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([ada682a](iamkun/dayjs@ada682a))
* update Catalan [ca] locale ordinal ([59c8449](iamkun/dayjs@59c8449))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([d6154de](iamkun/dayjs@d6154de))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([e3420de](iamkun/dayjs@e3420de))
* Update objectSupport plugin to return current date time while parsing empty object ([fe63212](iamkun/dayjs@fe63212))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbleduigou @iamkun @Qrymy