Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

umd package in esmodule 'this' error #1060

Closed
iamkun opened this issue Sep 20, 2020 · 1 comment · Fixed by #1453
Closed

umd package in esmodule 'this' error #1060

iamkun opened this issue Sep 20, 2020 · 1 comment · Fixed by #1453
Labels
☢️Bug Something isn't working released

Comments

@iamkun
Copy link
Owner

iamkun commented Sep 20, 2020

If we use Day.js in browser through <script type="module"> import, there will be a this undefined problem.

Possible fix sulotion: upgrade rollup rollup/rollup#3666
@iamkun iamkun added the ☢️Bug Something isn't working label Sep 20, 2020
@aloisklink aloisklink mentioned this issue Apr 12, 2021
Merged
@iamkun
Copy link
Owner Author

iamkun commented May 26, 2021

🎉 This issue has been resolved in version 1.10.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️Bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken UTC plugin due to rollup aloisklink/dayjs
1 participant
@iamkun