Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keychain-azure-kv): create azure key vault plugin #971

Closed
jagpreetsinghsasan opened this issue May 19, 2021 · 0 comments · Fixed by #991
Closed

feat(keychain-azure-kv): create azure key vault plugin #971

jagpreetsinghsasan opened this issue May 19, 2021 · 0 comments · Fixed by #991
Assignees
@jagpreetsinghsasan
Labels
Developer_Experience good-first-issue Good for newcomers good-first-issue-200-intermediate Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.

Comments

@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented May 19, 2021 •
edited
Loading

Description

As a developer, I want to create a plugin for aws secret manager and perform tasks related to secret management like createSecret and retrieveSecret sort of functionalities.

For reference,
https://docs.microsoft.com/en-in/azure/key-vault/

Acceptance Criteria

  1. New package to be created as @hyperledger/cactus-plugin-keychain-azure-kv
  2. Plugin must implement the central keychain plugin Typescript interface we have in the core-api package
  3. The helper class to have methods to expose the credentials, port numbers, etc. that are required to configure/instantiate the PluginKeychainAzureKv class which is to be implemented as part of the package from point 1)

cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @petermetz @arnab-roy
@jagpreetsinghsasan jagpreetsinghsasan added Developer_Experience Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves. good-first-issue Good for newcomers good-first-issue-200-intermediate labels May 19, 2021
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 27, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
273c69e 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts
        Refactorings that were also necessary to incorporate 1) and 2)

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue May 27, 2021
Merged
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 27, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
35e7942 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 28, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
af08de8 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue May 28, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
b3748f1 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 1, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
aec199e 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 5, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
ac7e309 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 5, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
fae3cc0 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 7, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
c16586d 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 7, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
3a06dc8 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 11, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
b58059a 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jun 15, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
f5a7455 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 6, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
431c5af 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
035d741 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
96e6e22 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 22, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
3a9304a 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 26, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
b48d11a 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan added a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 28, 2021
@jagpreetsinghsasan
feat(azure-kv): added keychain plugin for azure keyvault
73b62bb 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Jul 28, 2021
@jagpreetsinghsasan @petermetz
feat(azure-kv): added keychain plugin for azure keyvault
d325467 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz pushed a commit that referenced this issue Jul 29, 2021
@jagpreetsinghsasan @petermetz
feat(azure-kv): added keychain plugin for azure keyvault
69e7b50 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves #971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
hanxu12 pushed a commit to hanxu12/cactus that referenced this issue Aug 9, 2021
@jagpreetsinghsasan @hanxu12
feat(azure-kv): added keychain plugin for azure keyvault
e78e5e4 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Signed-off-by: hxlaf <xuhan@lafayette.edu>
Jeff-Ushry pushed a commit to Jeff-Ushry/cactus that referenced this issue Aug 11, 2021
@jagpreetsinghsasan @Jeff-Ushry
feat(azure-kv): added keychain plugin for azure keyvault
e5bf212 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Aug 20, 2021
@jagpreetsinghsasan @Leeyoungone
feat(azure-kv): added keychain plugin for azure keyvault
5a239ec 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone pushed a commit to Leeyoungone/cactus that referenced this issue Aug 23, 2021
@jagpreetsinghsasan @Leeyoungone
feat(azure-kv): added keychain plugin for azure keyvault
78b387b 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone pushed a commit to Jeff-Ushry/cactus that referenced this issue Aug 24, 2021
@jagpreetsinghsasan @Leeyoungone
feat(azure-kv): added keychain plugin for azure keyvault
4255231 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone pushed a commit to Jeff-Ushry/cactus that referenced this issue Aug 24, 2021
@jagpreetsinghsasan @Leeyoungone
feat(azure-kv): added keychain plugin for azure keyvault
cc82cc5 
        Primary Change
        ---
        1. Added new package cactus-plugin-keychain-azure-kv under packages/
        2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@jagpreetsinghsasan @RafaelAPB
feat(azure-kv): added keychain plugin for azure keyvault
20c3ac2 
	Primary Change
	---
	1. Added new package cactus-plugin-keychain-azure-kv under packages/
	2. Added PluginKeychainAzureKvMock class to mock the functions of SecretClient under
	packages/cactus-plugin-keychain-azure-kv/src/test/typescript/mock/plugin-keychain-azure-kv-mock.ts

Resolves hyperledger#971

Signed-off-by: jagpreetsinghsaan <jagpreet.singh.sasan@accenture.com>
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
Developer_Experience good-first-issue Good for newcomers good-first-issue-200-intermediate Keychain Tasks/bugs related to the Keychain plugin core interfaces or any of the implementations themselves.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(azure-kv): added keychain plugin for azure keyvault jagpreetsinghsasan/cactus
1 participant
@jagpreetsinghsasan