feat(test-tooling): utility function prune-docker-all-if-github-action #696
Assignees
Labels
Comments
|
⏳ Alright! Looks like we need to wait for some dependencies: 💡 Don't worry, I will continue watching the list above and keep this comment updated. To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Mar 22, 2021
…edger#696 Primary change -------------- Added a convenience function that tests can call in order to easily get rid of dangling docker resources that could be eating up the file system's available space on disk (which is an issue that we've started hitting more and more as we kept increasing the number of test cases that use containers for end to end testing). A good problem to have but nevertheless it is a problem that we need to be vigilant about cleaning up after our test cases to avoid overusing the resources of the CI runner. Miscellaneous change(s) ----------------------- Also added another utility function to determine if the current code is being executed in a GitHub Action Workflow runner or not. The presence and value of an environment variable is used to achieve this feat so it definitely is not bullet proof but the trade- off seemed fair given that these utility functions are only meant to be used by the test code anyway. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Mar 22, 2021
…edger#696 Primary change -------------- Added a convenience function that tests can call in order to easily get rid of dangling docker resources that could be eating up the file system's available space on disk (which is an issue that we've started hitting more and more as we kept increasing the number of test cases that use containers for end to end testing). A good problem to have but nevertheless it is a problem that we need to be vigilant about cleaning up after our test cases to avoid overusing the resources of the CI runner. Miscellaneous change(s) ----------------------- Also added another utility function to determine if the current code is being executed in a GitHub Action Workflow runner or not. The presence and value of an environment variable is used to achieve this feat so it definitely is not bullet proof but the trade- off seemed fair given that these utility functions are only meant to be used by the test code anyway. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this issue
Mar 23, 2021
Primary change -------------- Added a convenience function that tests can call in order to easily get rid of dangling docker resources that could be eating up the file system's available space on disk (which is an issue that we've started hitting more and more as we kept increasing the number of test cases that use containers for end to end testing). A good problem to have but nevertheless it is a problem that we need to be vigilant about cleaning up after our test cases to avoid overusing the resources of the CI runner. Miscellaneous change(s) ----------------------- Also added another utility function to determine if the current code is being executed in a GitHub Action Workflow runner or not. The presence and value of an environment variable is used to achieve this feat so it definitely is not bullet proof but the trade- off seemed fair given that these utility functions are only meant to be used by the test code anyway. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jordigiam
pushed a commit
to kikoncuo/cactus
that referenced
this issue
Apr 8, 2021
…edger#696 Primary change -------------- Added a convenience function that tests can call in order to easily get rid of dangling docker resources that could be eating up the file system's available space on disk (which is an issue that we've started hitting more and more as we kept increasing the number of test cases that use containers for end to end testing). A good problem to have but nevertheless it is a problem that we need to be vigilant about cleaning up after our test cases to avoid overusing the resources of the CI runner. Miscellaneous change(s) ----------------------- Also added another utility function to determine if the current code is being executed in a GitHub Action Workflow runner or not. The presence and value of an environment variable is used to achieve this feat so it definitely is not bullet proof but the trade- off seemed fair given that these utility functions are only meant to be used by the test code anyway. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
As a contributor I want to have a convenience function to call when I need to clean up before and after my test cases so that I'm more productive when working on Cactus.
Depends on #694
Acceptance Criteria
cc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton @AzaharaC @jordigiam @kikoncuo @jagpreetsinghsasan
The text was updated successfully, but these errors were encountered: