fix(cockpit): compilation issues #496
Labels
bug
Something isn't working
Developer_Experience
good-first-issue
Good for newcomers
Hacktoberfest
Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Milestone
Comments
petermetz
added
bug
petermetz
added a commit
to petermetz/cacti
that referenced
this issue
Jan 15, 2021
The full build with frontend components included are now working once again. 1. The cockpit components no longer depend on the api-client package shipping the standard typescript-axios client types such as DefaultApi, Configuration and the likes. This is because we hollowed out the client-api package to only contain the extensions to these generated types mentioned above (provided via typescript-axios OpenAPI generator) This is part of a larger ongoing effort where we decoupled the api-client and the cmd-api-server packages where earlier there was some tangling between the two in the form of the cmd-api-server exporting it's openapi spec onto the api-client package which in hindsight didn't make much sense to be honest. Mistakes were made, but now are being fixed. 2. A related, but not strictly necessary, cleanup type of change is that we also deleted the remnants of the generated code from the api-client package, e.g. the whole ./generated/openapi/typescrit-axios/ folder is now gone properly (it didn't have any actual Typescript code at this point anyway due to the ongoing changes on other works streams that were pointed out above as well.) Fixes hyperledger#496 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this issue
Jan 19, 2021
The full build with frontend components included are now working once again. 1. The cockpit components no longer depend on the api-client package shipping the standard typescript-axios client types such as DefaultApi, Configuration and the likes. This is because we hollowed out the client-api package to only contain the extensions to these generated types mentioned above (provided via typescript-axios OpenAPI generator) This is part of a larger ongoing effort where we decoupled the api-client and the cmd-api-server packages where earlier there was some tangling between the two in the form of the cmd-api-server exporting it's openapi spec onto the api-client package which in hindsight didn't make much sense to be honest. Mistakes were made, but now are being fixed. 2. A related, but not strictly necessary, cleanup type of change is that we also deleted the remnants of the generated code from the api-client package, e.g. the whole ./generated/openapi/typescrit-axios/ folder is now gone properly (it didn't have any actual Typescript code at this point anyway due to the ongoing changes on other works streams that were pointed out above as well.) Fixes #496 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
This is an issue that only manifests itself when running the
./tools/ci.shscript which compiles everything for every scenario.The GH actions initially did not do this because it was much easier to test/refine them/their config by just including specific
npm tasks.
There will be another issue open for rectifying that which will depend on this having been fixed first.
To Reproduce
cd cactus./tools/ci.shExpected behavior
Process exit code of
0Logs/Stack traces
The API client's method names are outdated and that fails the Typescript compilation for some of the front-end components such as the cockpit or the supply-chain-app front-end.
Cloud provider or hardware configuration:
Dev machine.
Operating system name, version, build:
Use this command:
printf "$(uname -srm)\n$(cat /etc/os-release)\n"For example
Hyperledger Cactus release version or commit (git rev-parse --short HEAD):
0.3.0andmaincc: @takeutak @sfuji822 @hartm @jonathan-m-hamilton
The text was updated successfully, but these errors were encountered: