Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(connector-iroha): fix and unskip run-transaction-endpoint-v1.test #1957

Closed
petermetz opened this issue Apr 1, 2022 · 3 comments
Closed

test(connector-iroha): fix and unskip run-transaction-endpoint-v1.test #1957

petermetz opened this issue Apr 1, 2022 · 3 comments
Assignees
@Leeyoungone
Labels
bug Something isn't working Developer_Experience Iroha Bugs/features related to the Iroha ledger connector plugin P2 Priority 2: High

Comments

@petermetz
Copy link
Member

Description

Currently this test case is being skipped due to issues with the Iroha AIO
image:
packages/cactus-plugin-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts

Acceptance criteria

  1. The mentioned test is once again part of the CI and it passes consistently.
@petermetz petermetz added bug Something isn't working Developer_Experience Iroha Bugs/features related to the Iroha ledger connector plugin P2 Priority 2: High labels Apr 1, 2022
This was referenced Apr 1, 2022
Open
Closed
@Leeyoungone Leeyoungone mentioned this issue Apr 12, 2022
Merged
@Leeyoungone
Copy link
Contributor

Hey @petermetz, just wanted to let you know that I've ran the test case at least 20 times (without any changes except not skipping the test cases anymore) and it has passed every single one of them. I've put up an issue mentioning this "fix" where I got rid of the .skip, let me know your thoughts

@petermetz
Copy link
Member Author

Hey @petermetz, just wanted to let you know that I've ran the test case at least 20 times (without any changes except not skipping the test cases anymore) and it has passed every single one of them. I've put up an issue mentioning this "fix" where I got rid of the .skip, let me know your thoughts

@Leeyoungone Nice, let's see how it goes. I don't remember for sure if we skipped it because it wasn't working at all or if it was flaky. We can start not skipping it and monitor the CI runs on unrelated PRs for failures due to this test case (if it starts being flaky we'll have to reverse your change and reopen this issue until we figure out the reason for the flaky execution of the test case)

@Leeyoungone
Copy link
Contributor

@petermetz sounds good! thanks for your thoughts :))

Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Apr 20, 2022
@Leeyoungone
fix: remove skip to pass test case
78e6898 
removal of skip resulted in the test case passing over 20 times, might still be flaky.

Fixes hyperledger#1957
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Apr 20, 2022
@Leeyoungone
fix: remove skip to pass test case
879eb13 
Currently this test case is being skipped due to issues with the Iroha AIO
image:
packages/cactus-plugin-ledger-connector-iroha/src/
test/typescript/integration/
run-transaction-endpoint-v1.test.ts
removal of skip resulted in the test case passing over 20 times, might still be flaky.

Fixes hyperledger#1957
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
petermetz pushed a commit to Leeyoungone/cactus that referenced this issue May 10, 2022
@Leeyoungone @petermetz
fix: remove skip to pass test case
d1a31c7 
Currently this test case is being skipped due to issues with the Iroha AIO
image:
packages/cactus-plugin-ledger-connector-iroha/src/
test/typescript/integration/
run-transaction-endpoint-v1.test.ts
removal of skip resulted in the test case passing over 20 times, might still be flaky.

Fixes hyperledger#1957
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue May 10, 2022
@Leeyoungone
fix: remove skip to pass test case
32ce2c0 
Currently this test case is being skipped due to issues with the Iroha AIO
image:
packages/cactus-plugin-ledger-connector-iroha/src/
test/typescript/integration/
run-transaction-endpoint-v1.test.ts
removal of skip resulted in the test case passing over 20 times, might still be flaky.

Fixes hyperledger#1957
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
petermetz pushed a commit to Leeyoungone/cactus that referenced this issue May 10, 2022
@Leeyoungone @petermetz
fix: remove skip to pass test case
9370529 
Currently this test case is being skipped due to issues with the Iroha AIO
image:
packages/cactus-plugin-ledger-connector-iroha/src/
test/typescript/integration/
run-transaction-endpoint-v1.test.ts
removal of skip resulted in the test case passing over 20 times, might still be flaky.

Fixes hyperledger#1957
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
zondervancalvez pushed a commit to zondervancalvez/cactus that referenced this issue May 18, 2022
@Leeyoungone @zondervancalvez
fix: remove skip to pass test case
2763941 
Currently this test case is being skipped due to issues with the Iroha AIO
image:
packages/cactus-plugin-ledger-connector-iroha/src/
test/typescript/integration/
run-transaction-endpoint-v1.test.ts
removal of skip resulted in the test case passing over 20 times, might still be flaky.

Fixes hyperledger#1957
Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leeyoungone Leeyoungone

Labels
bug Something isn't working Developer_Experience Iroha Bugs/features related to the Iroha ledger connector plugin P2 Priority 2: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petermetz @Leeyoungone