Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade to Typescript v4.4 #1129

Closed
petermetz opened this issue Jul 13, 2021 · 2 comments
Closed

build(deps): upgrade to Typescript v4.4 #1129

petermetz opened this issue Jul 13, 2021 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file Developer_Experience Epic good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have

Comments

@petermetz
Copy link
Member

petermetz commented Jul 13, 2021

Description

Currently we use tsc 4.3.x or similar but 4.4 is now in public beta1 and have a couple of very cool features that we want to start using as soon as possible to increase code quality in the project.

Specifically want to leverage this2 feature which should make it so that if Checks.truthy(...) was used to assert that something is truthy, then in the following line the compiler will recognize this at compile time (which it hasn't done so before)

Acceptance Criteria

  1. Wait until 4.4 comes out of beta (but we can start testing today so that as soon as it hits GA, we can pull the plug with the upgrade)
  2. The Typescript compiler dependency is updated to 4.4
  3. CI is passing still
$ yarn lerna ls
yarn run v1.18.0
lerna notice cli v4.0.0
@hyperledger/cactus-example-carbon-accounting-backend
@hyperledger/cactus-example-carbon-accounting-business-logic-plugin
@hyperledger/cactus-example-carbon-accounting-frontend
@hyperledger/cactus-example-supply-chain-backend
@hyperledger/cactus-example-supply-chain-business-logic-plugin
@hyperledger/cactus-example-supply-chain-frontend
@hyperledger/cactus-plugin-htlc-coordinator-besu
@hyperledger/cactus-plugin-object-store-ipfs
@hyperledger/cactus-api-client
@hyperledger/cactus-cmd-api-server
@hyperledger/cactus-common
@hyperledger/cactus-core-api
@hyperledger/cactus-core
@hyperledger/cactus-plugin-consortium-manual
@hyperledger/cactus-plugin-htlc-eth-besu-erc20
@hyperledger/cactus-plugin-htlc-eth-besu
@hyperledger/cactus-plugin-keychain-aws-sm
@hyperledger/cactus-plugin-keychain-azure-kv
@hyperledger/cactus-plugin-keychain-google-sm
@hyperledger/cactus-plugin-keychain-memory-wasm
@hyperledger/cactus-plugin-keychain-memory
@hyperledger/cactus-plugin-keychain-vault
@hyperledger/cactus-plugin-ledger-connector-besu
@hyperledger/cactus-plugin-ledger-connector-corda
@hyperledger/cactus-plugin-ledger-connector-fabric-socketio
@hyperledger/cactus-plugin-ledger-connector-fabric
@hyperledger/cactus-plugin-ledger-connector-go-ethereum-socketio
@hyperledger/cactus-plugin-ledger-connector-iroha
@hyperledger/cactus-plugin-ledger-connector-quorum
@hyperledger/cactus-plugin-ledger-connector-sawtooth-socketio
@hyperledger/cactus-plugin-ledger-connector-xdai
@hyperledger/cactus-plugin-odap-hermes
@hyperledger/cactus-test-api-client
@hyperledger/cactus-test-cmd-api-server
@hyperledger/cactus-test-plugin-consortium-manual
@hyperledger/cactus-test-plugin-htlc-eth-besu-erc20
@hyperledger/cactus-test-plugin-htlc-eth-besu
@hyperledger/cactus-test-plugin-ledger-connector-besu
@hyperledger/cactus-test-plugin-ledger-connector-quorum
@hyperledger/cactus-test-tooling
lerna success found 40 packages
Done in 1.02s.

cc: @ty-lazar @Jeff-Ushry @twiggins120 @awadhana @Leeyoungone

@petermetz petermetz added good-first-issue Good for newcomers Nice-to-Have dependencies Pull requests that update a dependency file Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. good-first-issue-200-intermediate labels Jul 13, 2021
@Leeyoungone
Copy link
Contributor

May I take this one?

Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Oct 27, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 1, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 1, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 9, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 16, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 17, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 24, 2021
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Nov 24, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 7, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 20, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 20, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 23, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 29, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 29, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 29, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 30, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 30, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 30, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 30, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 30, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
Leeyoungone added a commit to Leeyoungone/cactus that referenced this issue Dec 30, 2021
Fixes hyperledger#1129

Signed-off-by: Youngone Lee <youngone.lee@accenture.com>
@petermetz petermetz added the Epic label Jan 10, 2022
@outSH
Copy link
Contributor

outSH commented Dec 19, 2023

4.9 is used now

@outSH outSH closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Developer_Experience Epic good-first-issue Good for newcomers good-first-issue-200-intermediate Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Nice-to-Have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants