You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pushed a potential fix as #2033 - the big open question is whether to keep this backwards-compatible and/or issue a warning if the mixin is still loading it from a pickle file
Thanks @bmuskalla! I continued the discussion on the PR directly. General guidelines is to prevent unannounced breaking changes as much as possible. So what we should do is to support safetensors right now and after a few releases, make it the default + slowly remove support for unsafe loading.
@NielsRogge this issue has been completed by @bmuskalla in #2033 and will be available in the soon-to-be-published release! Together with #2001 it fixes the biggest problems you've mentioned about the mixin right? (except handling sharding that should be done soon now that #1938 have been merged)
Is your feature request related to a problem? Please describe.
The PyTorchModelHubMixin currently saves weights as a
pytorch_model.bin
file, which is considered unsafe.Describe the solution you'd like
Would be great to update to leverage the
safetensors
format by default.Describe alternatives you've considered
/
Additional context
/
The text was updated successfully, but these errors were encountered: