Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the normalize and truncate parameters to feature_extraction to be compatible with Text Embeddings Inference (TEI) #1877

Closed
datavistics opened this issue Nov 30, 2023 · 1 comment

Comments

@datavistics
Copy link

Is your feature request related to a problem? Please describe.
I would like to be able to use feature_extraction with full compatibility with Text Embeddings Inference: https://huggingface.github.io/text-embeddings-inference/#/Text%20Embeddings%20Inference/embed

Describe the solution you'd like
We should add the ability to put truncate and normalize in the post call

Describe alternatives you've considered
Ive tried workarounds, which involve overwriting the methods, but my friends made fun of my ugly code.

@Wauplin
Copy link
Contributor

Wauplin commented Dec 18, 2023

As explained in #1885 (comment), I prefer to put this feature request on hold until we have a proper parameter definition for inference. For now, let's close as "won't fix" and we get back to it once we have a more global approach to this.

@Wauplin Wauplin closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants