Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OkHttp usage #312

Closed
ScottPierce opened this issue Nov 22, 2016 · 2 comments
Closed

Update OkHttp usage #312

ScottPierce opened this issue Nov 22, 2016 · 2 comments

Comments

@ScottPierce
Copy link

ScottPierce commented Nov 22, 2016 •
edited
Loading

OkUrlFactory is deprecated and will be removed in a newer version. It also seems you are using an old version of OkHttp in your OkHttpConnector, so it's not compatible.
@kohsuke
Copy link
Collaborator

kohsuke commented Nov 26, 2016

As you said, OkUrlFactory is deprecated in OkHttp3, so there's no easy way to implement HttpConnector for newer versions of OkHttp. I don't see anything this library could do here, and OkHttpConnector is a convenience extra and not a critical part of this library anyway.

@kohsuke kohsuke closed this as completed Nov 26, 2016
@rmetzger
Copy link
Contributor

rmetzger commented Feb 7, 2019

Another problem of the okhttp3.OkUrlFactory is that it does not support OkHttp interceptors, making logging of HTTP calls with OkHttp impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kohsuke @rmetzger @ScottPierce