Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OkHttp is out of date #290

Closed
mh-park opened this issue Jul 22, 2016 · 4 comments
Closed

OkHttp is out of date #290

mh-park opened this issue Jul 22, 2016 · 4 comments

Comments

@mh-park
Copy link

mh-park commented Jul 22, 2016

OkUrlFactory is deprecated, so using the Cache is not the same as described on homepage.

@Shredder121
Copy link
Contributor

When was it deprecated?
We're still on OkHttp 2.x, and it's not deprecated for me.

@mh-park
Copy link
Author

mh-park commented Jul 22, 2016

It was deprecated later on in 2.x, and removed in 3.x.

Some extra clarification: If we are to use this github library with the most recent version (3.4.1) of OkHttp (let's say, to use a cache like it says on http://github-api.kohsuke.org/), we wouldn't be able to because OkUrlFactory doesn't exist anymore.

@Shredder121
Copy link
Contributor

If we are to use this github library with the most recent version (3.4.1) of OkHttp

That isn't possible, since they changed package names as well.
So all classes (as we use them in github-api don't "exist" anymore.

But which version was it deprecated then?
I'm on 2.7.5, and see no such deprecation.

@kohsuke
Copy link
Collaborator

kohsuke commented Aug 6, 2016

Looks like OkUrlFactory is being deprecated in OkHttp 3.x. From their javadoc:

/**
 * @deprecated OkHttp will be dropping its ability to be used with {@link HttpURLConnection} in an
 * upcoming release. Applications that need this should either downgrade to the system's built-in
 * {@link HttpURLConnection} or upgrade to OkHttp's Request/Response API.
 */

I don't think there's anything this library can do here.

@kohsuke kohsuke closed this as completed Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants