Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Trees support #153

Closed
ddtxra opened this issue Feb 13, 2015 · 3 comments
Closed

Github Trees support #153

ddtxra opened this issue Feb 13, 2015 · 3 comments

Comments

@ddtxra
Copy link
Contributor

ddtxra commented Feb 13, 2015

Hello,
Thanks for this wonderful library!

I would like the library to support github trees, is it foreseen (https://developer.github.com/v3/git/trees/)?
For instance I need to retrieve this:
https://api.github.com/repos/calipho-sib/nextprot-docs/git/trees/master?recursive=1

If you would like I can try to implement this feature and I make a pull request?
@kohsuke
Copy link
Collaborator

kohsuke commented Feb 15, 2015

Yes, a pull request would be wonderful. It should probably be a method on GHCommit.

@ddtxra
Copy link
Contributor Author

ddtxra commented Feb 18, 2015

Hi @kohsuke ,
I thought to implements the trees the same way as the refs. So it could be called as a method of GHRepository, the same way the GHRef works. Does it make sense?

@ddtxra
Copy link
Contributor Author

ddtxra commented Feb 24, 2015

I have sent the pull request

@ddtxra ddtxra closed this as completed Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kohsuke @ddtxra