Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the old "--capability" command-line arguments #256

Closed
Michael-F-Bryan opened this issue Aug 17, 2021 · 0 comments · Fixed by #257
Closed

Remove the old "--capability" command-line arguments #256

Michael-F-Bryan opened this issue Aug 17, 2021 · 0 comments · Fixed by #257
Labels
area - runtime The Rust Rune runtime category - intuitiveness Something which may be unintuitive to the user or affect ergonomics category - refactor Internal code changes or reworking that aren't directly visible to the user effort - easy This should be pretty simple

Comments

@Michael-F-Bryan
Copy link
Contributor

We used to use --capability image:person.png for passing capabilities in from the command-line, but in #169 we decided it would be better to use --image person.png (more ergonomic, auto-complete, etc.).

Now that most of our users and documentation are using the more ergonomic version, let's nuke the old --capability argument and get rid of this mess.

CC: @jacekpie
@Michael-F-Bryan Michael-F-Bryan added area - runtime The Rust Rune runtime category - intuitiveness Something which may be unintuitive to the user or affect ergonomics category - refactor Internal code changes or reworking that aren't directly visible to the user effort - easy This should be pretty simple labels Aug 18, 2021
@Michael-F-Bryan Michael-F-Bryan mentioned this issue Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area - runtime The Rust Rune runtime category - intuitiveness Something which may be unintuitive to the user or affect ergonomics category - refactor Internal code changes or reworking that aren't directly visible to the user effort - easy This should be pretty simple
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the old "--capability" command-line arguments hotg-ai/rune
1 participant
@Michael-F-Bryan