Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize images when the image capability's width/height parameters are set #170

Closed
Michael-F-Bryan opened this issue May 23, 2021 · 0 comments · Fixed by #180
Closed

Resize images when the image capability's width/height parameters are set #170

Michael-F-Bryan opened this issue May 23, 2021 · 0 comments · Fixed by #180

Comments

@Michael-F-Bryan
Copy link
Contributor

@kthakore noticed that we are just emit a warning when the height and width arguments are provided to an IMAGE capability.

[2021-05-23T18:48:39.091Z WARN  rune_runtime::common_capabilities::image] Unknown parameter: "width" = 224_i32
[2021-05-23T18:48:39.091Z WARN  rune_runtime::common_capabilities::image] Unknown parameter: "height" = 224_i32

On further inspection it looks like we only handle the pixel_format argument and will need to add some image resizing methods to our ProcessedImage type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant