Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation saying the tsdownsample algorithm is available #6080

Open
hoxbro opened this issue Jan 23, 2024 · 7 comments
Open

Add documentation saying the tsdownsample algorithm is available #6080

hoxbro opened this issue Jan 23, 2024 · 7 comments
Labels
good first issue An issue well suited to a new contributor type: docs Related to the documentation and examples

Comments

@hoxbro
Copy link
Member

hoxbro commented Jan 23, 2024

#6059 added tsdownsample algorithms. We should, at a minimum, update the documentation to mention it.

Right now the other downsamples are mentioned here: https://holoviews.org/user_guide/Large_Data.html#working-with-time-series

@hoxbro hoxbro added type: docs Related to the documentation and examples good first issue An issue well suited to a new contributor labels Jan 23, 2024
@Victorasuquo
Copy link

on this now

@droumis
Copy link
Member

droumis commented Mar 5, 2024

Hi @Victorasuquo , were you planning on submitting a PR to address this issue?

@Victorasuquo
Copy link

yes

@droumis
Copy link
Member

droumis commented Apr 15, 2024

@Victorasuquo, we are planning to release the next HoloViews version in the coming days which includes new tsdownsample algorithms, which still needs docs. Do you have a PR for us to review? Otherwise, we may have to go ahead and add a first version of these docs, and perhaps then you could improve them after that

@droumis
Copy link
Member

droumis commented Apr 15, 2024

Here are some notes:

Enhanced Downsampling Options

Starting in HoloViews version 1.19.0, integration with the tsdownsample library introduces enhanced downsampling algorithms, e.g. via downsample1d(curve, algorithm='minmax') :

  • lttb: Implements the Largest Triangle Three Buckets (LTTB) algorithm, optimizing the selection of points to retain the visual shape of the data.
  • minmax: For each segment of the data, this method retains the minimum and maximum values, ensuring that peaks and troughs are preserved.
  • minmax-lttb: A hybrid approach that combines the minmax strategy with LTTB.
  • m4: A multi-step process that leverages the min, max, first, and last values for each time segment.

@Victorasuquo
Copy link

okay thanks for the hints, I will continue with this

@droumis
Copy link
Member

droumis commented Apr 29, 2024

Hi @Victorasuquo, what is your timeline for this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue well suited to a new contributor type: docs Related to the documentation and examples
Projects
None yet
Development

No branches or pull requests

3 participants