Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique selectors for library styling #2

Closed
himynameisdave opened this issue Apr 6, 2020 · 1 comment
Closed

Unique selectors for library styling #2

himynameisdave opened this issue Apr 6, 2020 · 1 comment

Comments

@himynameisdave
Copy link
Owner

Working in a larger codebase, you're likely to have a .flex class already. Libraries like this should user something more unique to ensure that there isn't an unintended inheritance.

I'm partial to [data-*] selectors, but a scoped class like svelte-flex__flex would work.

Ideally, it should be a selector which svelte can mangle into something smaller at compile time.

Taken from this comment.

@himynameisdave
Copy link
Owner Author

This is resolved by #22, since now we just use style directives and no .flex class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant