Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .vscode to gitignore #644

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Added .vscode to gitignore #644

merged 1 commit into from
Feb 19, 2024

Conversation

jounathaen
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7462d4) 65.41% compared to head (61ab556) 65.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   65.41%   65.41%           
=======================================
  Files          18       18           
  Lines        2134     2134           
=======================================
  Hits         1396     1396           
  Misses        738      738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkroening
Copy link
Member

This should be part of the user's global .gitignore. We can't cater for all possible editors.

@jounathaen
Copy link
Member Author

I do basically agree with you, but I think there are a few reasons to make an exception here:

  • vscode is not just any editor, but currently the de-facto editor that most people using uhyve are using:
    • As many people are not aware of global .gitignores, this is results in people adding this to their .gitignore and commit it accidentally, making it part of commits that have other goals.
    • In some projects it does make a lot of sense to add the .vscode to the repository, e.g., to have shared launch configurations. A global .gitignore makes this more complicated. As we don't have this use case, we can simply add it to the gitignore.

@mkroening mkroening added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit c09d3ef Feb 19, 2024
11 checks passed
@mkroening mkroening deleted the gitignore branch February 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants