Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests: Use default profile #195

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Integration tests: Use default profile #195

merged 1 commit into from
Sep 22, 2021

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Sep 10, 2021 •
edited
Loading

For easy integration tests of gdbstub, I need the dev opt-level to be 0.

On release, opt-level is 3 by default.

@codecov
Copy link

codecov bot commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #195 (7b91cca) into master (71ac00c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   20.49%   20.49%           
=======================================
  Files          17       17           
  Lines        2654     2654           
=======================================
  Hits          544      544           
  Misses       2110     2110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ac00c...7b91cca. Read the comment docs.

@mkroening mkroening requested review from stlankes and removed request for jounathaen September 10, 2021 15:30
@stlankes
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Sep 12, 2021
@bors @mkroening
Merge #195 #197 #200
89244ae 
195: Integration tests: Use default profile r=stlankes a=mkroening

For easy integration tests of gdbstub, I need the `dev ` `opt-level` to be 0.

On `release`, `opt-level` is 3 by default.

197: CI: Download Git-LFS files r=stlankes a=mkroening

This is required for the [`test_vm.*`](https://github.com/hermitcore/uhyve/blob/3b70087e3612e55ddce7888ce1b9fe91ca8596c9/src/vm.rs#L856-L907) to work correctly. Without this, they are not operating on the real files, but mere placeholders.

We need `git-lfs` to be installed on our runner for this.

Found via #192.

200: CI: Capture test output r=stlankes a=mkroening

This avoids GitHub check annotations about expected panics.

This reverts 4e222b7.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@stlankes
Copy link
Collaborator

bors r-

@bors
Copy link
Contributor

bors bot commented Sep 12, 2021

Canceled.

@stlankes
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Sep 12, 2021
@bors
Try #195:
1c193ca
@bors
Copy link
Contributor

bors bot commented Sep 12, 2021

try

Build succeeded:

@mkroening mkroening mentioned this pull request Sep 17, 2021
Merged
@jounathaen
Copy link
Member

@mkroening have you investigated, why this test fails?

@mkroening
Copy link
Member Author

The failure should be spurious.

bors try

While opt-level = 0 works in these integration tests, they are not supported yet for all rusty-hermit applications (hermit-os/hermit-rs#157). So we could merge this now, or wait.

bors bot added a commit that referenced this pull request Sep 21, 2021
@bors
Try #195:
9b3d903
@bors
Copy link
Contributor

bors bot commented Sep 21, 2021

try

Build succeeded:

@jounathaen
Copy link
Member

Well, this only affects the integration tests, so we can merge it now. I'm just curious why it failed before.
I hope this won't become an issue in the long run.

But nevertheless: bors r+
And thanks for all the fish (and the contribution 😉 )

@mkroening
Copy link
Member Author

As I said, the failure was spurious and had nothing to do with this PR.

Bors commands have to be at a newline:
bors r=jounathaen

@bors
Copy link
Contributor

bors bot commented Sep 22, 2021

Build succeeded:

@bors bors bot merged commit e8b410d into hermit-os:master Sep 22, 2021
@mkroening mkroening deleted the profile branch September 22, 2021 15:18
bors bot added a commit that referenced this pull request Sep 27, 2021
@bors @mkroening
Merge #205
498b98b 
205: Add gdbstub integration test r=jounathaen a=mkroening

This depends on #195, but is ready for review.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlankes stlankes Awaiting requested review from stlankes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkroening @stlankes @jounathaen