Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concrete vCPU structs instead of trait objects #186

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

mkroening
Copy link
Member

In #164, I implement additional traits for UhyveCPU on linux, but not on macos.

To be able to use the trait impls, this makes the vCPU structs concrete instead of using trait objects.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #186 (63fa348) into master (095579f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   30.76%   30.76%           
=======================================
  Files          16       16           
  Lines        4018     4018           
=======================================
  Hits         1236     1236           
  Misses       2782     2782           
Impacted Files Coverage Δ
src/linux/mod.rs 0.00% <ø> (ø)
src/linux/uhyve.rs 53.77% <0.00%> (ø)
src/linux/virtio.rs 9.13% <0.00%> (ø)
src/vm.rs 28.35% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095579f...63fa348. Read the comment docs.

@jounathaen
Copy link
Member

Nice!
bors r+

@bors bors bot merged commit f66738f into hermit-os:master Sep 7, 2021
@mkroening mkroening deleted the no-dyn branch September 7, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants