RPB-80 add missing allegro fields #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acka47
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Wir hatten ja die Sortierung u.a. ergänzt, damit ich im Diff gut sehen und reviewen kann, ob die Allegro-Ergänzungen so passen. Jetzt ist aber in 0055e0e doch die ganze Datei ersetzt, weshalb ich das nicht gut reviewen kann.
Hast du vor dem Committen nochmal die Sortierung durchlaufen lassen? Evtl. hat sich auch etwas bei der Einrückung geändert (vielleicht unterschiedliche Editor-Einstellung an verschiedenen Rechnern?), bin mir da aber nicht sicher.
Auf jeden Fall wäre es gut, wenn du den letzten Commit ersetzen könntest. (Meinetwegen in dem Fall auch gerne force pushen.)
|
Es gibt einen neuen PR für diese Änderungen (#226), so dass ich diesen hier schließe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort ttl by prefix, ConceptScheme, notation
#rpb-80